[No QA] Set the user preferences correctly on Onyx #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thienlnam
reviewed
Jun 22, 2021
| @@ -69,7 +69,7 @@ function getUserDetails() { | |||
| // Update the User onyx key | |||
| const loginList = _.where(response.loginList, {partnerName: 'expensify.com'}); | |||
| const expensifyNewsStatus = lodashGet(response, 'account.subscribed', true); | |||
| Onyx.merge(ONYXKEYS.USER, {loginList, expensifyNewsStatus}); | |||
| Onyx.merge(ONYXKEYS.USER, {loginList, expensifyNewsStatus: !!expensifyNewsStatus}); | |||
There was a problem hiding this comment.
Curious why we're using evaluating to a truthy value here, what is the expected value of expensifyNewsStatus? A number?
There was a problem hiding this comment.
the Api returns Int 1, 0 and we want to save Boolean
thienlnam
approved these changes
Jun 22, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jun 22, 2021
|
🚀 Deployed to staging in version: 1.0.73-4🚀
|
|
🚀 Deployed to production in version: 1.0.74-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
Fixes #3569
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android